Skip to content

Teddy.gesbert/doc dora #29393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
May 16, 2025
Merged

Teddy.gesbert/doc dora #29393

merged 35 commits into from
May 16, 2025

Conversation

Tecoddy
Copy link
Contributor

@Tecoddy Tecoddy commented May 16, 2025

What does this PR do? What is the motivation?

Updated the DORA Metrics limitations to better describe how do we handle rebasing.

Merge instructions

Merge readiness:

  • Ready for merge

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

Tecoddy and others added 30 commits March 17, 2025 18:43
Change deployment.merge_time to Merge Time (i.e. metric to field) to avoid any confusion with previous Metrics type
- Added consistency between data sources requirements.
- Remove /dora_metrics/failures/datadog_incidents alias as not needed.
Added backfill documentation for retrieving past incidents using Incident Management as a DORA failure source.
@Tecoddy Tecoddy requested review from a team as code owners May 16, 2025 12:02
@Tecoddy Tecoddy requested a review from GabrielAnca May 16, 2025 12:02
Copy link
Contributor

github-actions bot commented May 16, 2025

Preview links (active after the build_preview check completes)

Modified Files

@@ -29,7 +29,6 @@ further_reading:
<div class="alert alert-warning">DORA Metrics is not available in the selected site ({{< region-param key="dd_site_name" >}}) at this time.</div>
{{< /site-region >}}

<div class="alert alert-warning">DORA Metrics is in Preview.</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Copy link
Contributor

@GabrielAnca GabrielAnca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@Tecoddy
Copy link
Contributor Author

Tecoddy commented May 16, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 16, 2025

View all feedbacks in Devflow UI.

2025-05-16 14:35:29 UTC ℹ️ Start processing command /merge


2025-05-16 14:35:40 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 21m (p90).


2025-05-16 14:54:41 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit a2181c5 into master May 16, 2025
14 of 16 checks passed
@dd-mergequeue dd-mergequeue bot deleted the teddy.gesbert/doc-dora branch May 16, 2025 14:54
brantigua pushed a commit that referenced this pull request May 19, 2025
* Replaced incidents by failures

* v1

* v1.1

* Little update of some requirements (DORA settings)

* Upper case small changes

* Update content/en/dora_metrics/data_collected/_index.md

Co-authored-by: Jorge Calvar <[email protected]>

* Applied feedback from Jorge

Change deployment.merge_time to Merge Time (i.e. metric to field) to avoid any confusion with previous Metrics type

* Applied feedback from Guillaume

* Fix typos and improve consistency in DORA metrics documentation

Applied suggestions from Joe Peeples

* Applying Joe's feedback and fixing small tweak

* Added Incident Management as a DORA Failure data source

* Update content/en/dora_metrics/setup/failures.md

Co-authored-by: Alicia Scott <[email protected]>

* Update content/en/dora_metrics/setup/failures.md

Co-authored-by: Alicia Scott <[email protected]>

* Applied feedback from alicia

- Added consistency between data sources requirements.
- Remove /dora_metrics/failures/datadog_incidents alias as not needed.

* Applied feedback from Jorge

* Update content/en/dora_metrics/setup/failures.md

Co-authored-by: Alicia Scott <[email protected]>

* Update failures.md

* Added backfill documentation

Added backfill documentation for retrieving past incidents using Incident Management as a DORA failure source.

* Update content/en/dora_metrics/setup/failures.md

Co-authored-by: May Lee <[email protected]>

* Update content/en/dora_metrics/setup/failures.md

Co-authored-by: May Lee <[email protected]>

* Update content/en/dora_metrics/setup/failures.md

Co-authored-by: May Lee <[email protected]>

* Added, TTR calculation + Pro tips

* Added more details on TTR calculation

* Removing Preview alert

Removing Preview alert + 2 small changes on definitions

* Update documentation to add rebase logic

---------

Co-authored-by: Jorge Calvar <[email protected]>
Co-authored-by: Alicia Scott <[email protected]>
Co-authored-by: May Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants